Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseManifestsFromDir: improve filename handling #142

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@listx
Copy link
Contributor

listx commented Oct 11, 2019

The old code hardcoded a forward slash "/" character which would not
have worked on Windows.

/assign @justinsb

The old code hardcoded a forward slash "/" character which would not
have worked on Windows.
@justinsb

This comment has been minimized.

Copy link
Contributor

justinsb commented Oct 14, 2019

Thanks @listx

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 14, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, listx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e32056e into kubernetes-sigs:master Oct 14, 2019
5 checks passed
5 checks passed
cla/linuxfoundation listx authorized
Details
pull-cip-e2e Job succeeded.
Details
pull-cip-lint Job succeeded.
Details
pull-cip-unit-tests Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.