Enable verbose log lvl when passing --verbose flag #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This change fixes missing
logrus.Debug()
statements by explicitly setting the logging level. Now, when passing the--verbose
flag, we should be able to actually see verbose & request counter logs.Additionally, since the default logging level hides debug statement by default, we no longer need a serviceContext.Debug() wrapper. It's safe to define logrus.Debug, as only --verbose will trigger the log level change.
Supersedes #380
Which issue(s) this PR fixes:
Partially satisfies #358
Special notes for your reviewer:
Currently, when deploying the auditor with
--verbose
, we were unable to see any Debug logs. This PR should fix that problem.Does this PR introduce a user-facing change?
cc: @listx @amwat @justaugustus @kubernetes-sigs/release-engineering