Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Require nodepool.spec.template #657

Merged

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Nov 1, 2023

Fixes #N/A

Description

  • Require nodepool.spec.template to exist

How was this change tested?

  • Manually tested

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner November 1, 2023 21:21
@engedaam engedaam force-pushed the require-template-for-nodepool branch from 4b0afac to 1263cf8 Compare November 1, 2023 21:44
@engedaam engedaam force-pushed the require-template-for-nodepool branch from 1263cf8 to 7535c2d Compare November 1, 2023 21:55
@coveralls
Copy link

coveralls commented Nov 1, 2023

Pull Request Test Coverage Report for Build 6725450861

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.321%

Totals Coverage Status
Change from base Build 6725045244: 0.0%
Covered Lines: 8548
Relevant Lines: 10914

💛 - Coveralls

Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit fa801b9 into kubernetes-sigs:main Nov 2, 2023
6 checks passed
@engedaam engedaam deleted the require-template-for-nodepool branch November 2, 2023 00:10
jonathan-innis pushed a commit to jonathan-innis/karpenter that referenced this pull request Nov 21, 2023
jonathan-innis pushed a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants