nodeclassreadiness in nodepool status

[sadath-12]

Fixes #493 (nodeclass part)

Description

Users can inspect there nodeclass readiness in the status conditions of nodepool

How was this change tested?
make verify

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadath-12
Once this PR has been reviewed and has the lgtm label, please assign ellistarn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadath-12]

dup of #818 since I discarded those commits by miss . luckily had the backup of the code and pushed in this new branch

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

[jonathan-innis]

@sadath-12 Take a look at this controller and give your thoughts: https://github.com/jonathan-innis/karpenter/blob/requeue-on-gvk/pkg/controllers/state/informer/nodeclassref.go. This is my basic idea around throwing all updates for any NodeClass updates that we get into a global channel that can be watched-on by any controller that cares. I implemented the watch for the disruption controller here: https://github.com/jonathan-innis/karpenter/blob/requeue-on-gvk/pkg/controllers/nodeclaim/disruption/controller.go#L133 but you could imagine how this might extend to trigger requeues on the NodePool controller for Readiness updates.

[sadath-12]

Ya seems like a good way to do it . So are you getting the informer merged ? @jonathan-innis

[github-actions]

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

[jonathan-innis]

PR is blocked by support for requiring apiVersion and kind in the nodeClassRef field: #909

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Bryce-Soghigian]

/remove-lifecycle stale

[Bryce-Soghigian]

/lifecycle freeze

[jonathan-innis]

@engedaam Should have some thoughts around this PR. He was looking to leverage some of the work that he has been doing around the GetSupportedNodeClasses() function and the short requeue that would help us do this

[jonathan-innis]

/assign @engedaam

[engedaam]

Closing out this PR. Better to open a new PR, as it needs to be rebased

/close

[k8s-ci-robot]

@engedaam: Closed this PR.

In response to this:

Closing out this PR. Better to open a new PR, as it needs to be rebased

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.