Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename controllers constructors to NewController #826

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

This PR removes the calls that built the specific controller types when we were supporting both alpha and beta and replaces it with a call to just make NewController

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2023
@jonathan-innis jonathan-innis force-pushed the beta-renaming branch 3 times, most recently from 9b23927 to 5a6fd43 Compare November 28, 2023 23:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7025732502

  • 24 of 30 (80.0%) changed or added relevant lines in 6 files are covered.
  • 12 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.1%) to 79.439%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/consistency/controller.go 4 5 80.0%
pkg/controllers/nodeclaim/disruption/controller.go 4 5 80.0%
pkg/controllers/nodeclaim/lifecycle/controller.go 4 5 80.0%
pkg/controllers/nodeclaim/termination/controller.go 4 5 80.0%
pkg/controllers/nodepool/counter/controller.go 4 5 80.0%
pkg/controllers/nodepool/hash/controller.go 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/nodeclaim/consistency/controller.go 1 60.71%
pkg/controllers/nodeclaim/disruption/controller.go 1 53.73%
pkg/controllers/nodeclaim/lifecycle/controller.go 1 71.93%
pkg/controllers/disruption/drift.go 2 79.1%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 7025403617: -0.1%
Covered Lines: 7963
Relevant Lines: 10024

💛 - Coveralls

@engedaam
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 56012c2 into kubernetes-sigs:main Nov 29, 2023
8 checks passed
@jonathan-innis jonathan-innis deleted the beta-renaming branch November 29, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants