generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a validating webhook #89
Milestone
Comments
This was referenced Sep 27, 2022
in case RawArgs are set, webhook must make sure that -a option is not set ( -a option is not support by KMM) |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
label
Jan 18, 2023
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
label
Jan 18, 2023
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this issue
Jun 2, 2023
We have moved all the packages code to internal/ directory and this is some leftovers. Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this issue
Jun 2, 2023
Also add link to labs in main README.md
yevgeny-shnaidman
pushed a commit
to yevgeny-shnaidman/kernel-module-management-upstream
that referenced
this issue
Jul 31, 2023
We have moved all the packages code to internal/ directory and this is some leftovers. Signed-off-by: Yoni Bettan <yonibettan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some complex constraints cannot be expressed through kubebuilder / OpenAPI annotations.
To avoid errors at runtime, non-trivial validations are typically implemented in a Validating Admission Webhook. We should implement such a webhook to detect malformed
Modules
as early as possible.Checks:
Module
are validcontainerImage
field, unless.spec.moduleLoader.container.containerImage
is defined.spec.moduleLoader.container.modprobe.moduleName
is not empty unless bothmodprobe.rawArgs.load
andmodprobe.rawArgs.unload
are definedThe text was updated successfully, but these errors were encountered: