Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support runtimeClass feature #1042

Closed
gnmahanth opened this issue Nov 1, 2019 · 9 comments
Closed

Support runtimeClass feature #1042

gnmahanth opened this issue Nov 1, 2019 · 9 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@gnmahanth
Copy link

What would you like to be added:
Support Kubernetes runtimeClass feature
(https://kubernetes.io/docs/concepts/containers/runtime-class/)

Why is this needed:
If there is a need to test untrusted workload having a runtime like gvisor, ignite or kata will be helpful.
Since kind already have containerd as CRI and it can support multiple runtime through containerd plugins.

@gnmahanth gnmahanth added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 1, 2019
@BenTheElder
Copy link
Member

Ignite and kata are not going to work well inside the kind nodes (kvm being a non-containerized resource that we'd leak), though we'd like to use them as a backend for kind's nodes possibly at some point.

runsc in the default ptrace mode would actually probably be fine though 🤔

We'd have to look into the overhead.

@aojea
Copy link
Contributor

aojea commented Nov 2, 2019

For reference

https://github.com/gnmahanth/kind-runsc

thanks @gnmahanth , awesome work documenting it

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2020
@BenTheElder BenTheElder removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2020
@BenTheElder BenTheElder added this to the v0.9.0 milestone Apr 25, 2020
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2020
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jul 24, 2020
@BenTheElder BenTheElder removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2020
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Aug 20, 2020
@BenTheElder BenTheElder modified the milestones: v0.9.0, v0.10.0 Aug 26, 2020
@BenTheElder BenTheElder self-assigned this Aug 26, 2020
@BenTheElder
Copy link
Member

revisiting this in the next cycle.

@BenTheElder
Copy link
Member

BenTheElder commented Aug 27, 2020

One issue is:

gVisor builds on x86_64 and ARM64. Other architectures may become available in the future.

But Kubernetes supports more than this.

And in the install docs only x86_64 https://gvisor.dev/docs/user_guide/install/

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 25, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 2, 2022
@BenTheElder
Copy link
Member

Technically runtimeClass is supported, but we don't ship any special runtimeclasses1.

We're opting not to ship non-standard extensions otherwise at this time.

Footnotes

  1. We actually have to ship one "test" runtime class for testing Kubernetes, it is actually the same as the "normal" runtimeClass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants