Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to go 1.13.4 #1040

Merged
merged 1 commit into from
Nov 4, 2019
Merged

update to go 1.13.4 #1040

merged 1 commit into from
Nov 4, 2019

Conversation

BenTheElder
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2019
@BenTheElder
Copy link
Member Author

this one is the most interesting golang/go#35087

@BenTheElder
Copy link
Member Author

/hold
upstream has a flaking test regarding that change, which may be surfacing an actual issue, it doesn't seem clear yet.
see #sig-release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2019
@BenTheElder
Copy link
Member Author

/retest

@BenTheElder
Copy link
Member Author

Still need to check in on that upstream issue first but want to see if this works fine anyhow

@BenTheElder
Copy link
Member Author

golang/go#35087 (comment)
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2019
@aojea
Copy link
Contributor

aojea commented Nov 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit aea9a47 into kubernetes-sigs:master Nov 4, 2019
@BenTheElder BenTheElder deleted the 1134 branch November 4, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenTheElder @k8s-ci-robot @aojea