Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offline docs #1064

Merged
merged 3 commits into from
Apr 14, 2020
Merged

offline docs #1064

merged 3 commits into from
Apr 14, 2020

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Nov 6, 2019 •
edited
Loading

fix #345

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2019
@BenTheElder
Copy link
Member

rendered: https://deploy-preview-1064--k8s-kind.netlify.com/

@tao12345666333
Copy link
Member Author

What I am going to write includes two parts.

  1. Use an existing image (this process can also be considered offline when the image exists)

But the Pull image also needs the network, so I am not sure if I need to write it here. According to #331 (comment) it seems meaningful to write it. @BenTheElder WDYT?

  1. Build your own node image

@BenTheElder
Copy link
Member

But the Pull image also needs the network, so I am not sure if I need to write it here. According to #331 (comment) it seems meaningful to write it. @BenTheElder WDYT?

the node image must be obtained somehow, the easiest way is to pull it when you have network access.

it could also be transported to a machine by transfering a docker save style tarball

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2020
@tao12345666333
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2020
@tao12345666333
offline docs
42f78cd 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
using pre-build image
d4995d9 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2020
@tao12345666333 tao12345666333 marked this pull request as ready for review February 6, 2020 12:00
@tao12345666333 tao12345666333 changed the title [WIP] offline docs offline docs Feb 6, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2020
@tao12345666333
Copy link
Member Author

I didn't describe how to build own node image.
Because I found that the process of building an image is not very suitable for offline use.

@BenTheElder PTAL. Thanks.

@tao12345666333
Copy link
Member Author

https://deploy-preview-1064--k8s-kind.netlify.com/docs/user/working-offline/

@tao12345666333
Copy link
Member Author

/retest

@aojea
Copy link
Contributor

aojea commented Feb 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2020
@tao12345666333
Copy link
Member Author

ping @BenTheElder If you have time, PTAL. Thanks.

BenTheElder
BenTheElder reviewed Feb 10, 2020
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably mention side loading and if doing HA clusters the loadbalancer image?

site/content/docs/user/working-offline.md Outdated Show resolved Hide resolved
@BenTheElder
Copy link
Member

Image building should be fixed for offline as well but we can document it when that is true.

@tao12345666333
Copy link
Member Author

we should probably mention side loading and if doing HA clusters the loadbalancer image?

ok, I will add it.

Image building should be fixed for offline as well but we can document it when that is true.

If we build node-image with docker type (default), we need many other things like k8s.gcr.io/kube-cross image and some others for buil kubernetes.

It might be more convenient to use bazel, let me try! (I always using docker type)

@BenTheElder
Copy link
Member

It might be more convenient to use bazel, let me try! (I always using docker type)

bazel is maybe going away upstream

I would just document that you should build once online to let the upstream build tools fetch dependencies. this also applies to bazel, which I assure you downloads far more things than the make build.

@BenTheElder
Copy link
Member

sorry for the ridiculous delay here. everything is crazy right now :-)

@tao12345666333
Copy link
Member Author

Be careful 🐱

Let me update this PR.

@tao12345666333
Copy link
Member Author

bazel is maybe going away upstream

I see related issues kubernetes/kubernetes#88553

@tao12345666333
update offline doc about create HA cluster and building node image
f4db026 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2020
@tao12345666333
Copy link
Member Author

Add some contents about building node-image and create HA cluster.

@BenTheElder PTAL, thanks!

@tao12345666333
Copy link
Member Author

/test pull-kind-conformance-parallel-1-13

@tao12345666333
Copy link
Member Author

ping @BenTheElder PTAL.
Thanks. 😸

@BenTheElder
Copy link
Member

pong ... 8 days later.
my latency has gone up 😂 :this-is-fine:

@BenTheElder
Copy link
Member

/lgtm
/approve
we can iterate, this is a wonderful addition, thank you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 43711df into kubernetes-sigs:master Apr 14, 2020
@tao12345666333 tao12345666333 deleted the offline branch April 14, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat Awaiting requested review from amwat

@neolit123 neolit123 Awaiting requested review from neolit123

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@BenTheElder BenTheElder

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document offline clusters
5 participants
@tao12345666333 @BenTheElder @fejta-bot @aojea @k8s-ci-robot