Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1067

Merged
merged 6 commits into from Nov 7, 2019
Merged

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Nov 7, 2019

for the main kind CLI
will approach kindnetd carefully in a different PR at some point

EDIT:

  • switch to go-isatty which is a better scoped for checking if a file is a tty than x/crypto (and has version tags...)
  • drop superfluous uuid dependency, just use the timestamp and a random int for naming the node build container

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2019
@aojea
Copy link
Contributor

aojea commented Nov 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019
@BenTheElder
Copy link
Member Author

updated to cleanup the deps a bit (updated the PR body to describe)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -20,13 +20,13 @@ import (
"io"
"os"

"golang.org/x/crypto/ssh/terminal"
isatty "github.com/mattn/go-isatty"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot k8s-ci-robot merged commit f56b2cb into kubernetes-sigs:master Nov 7, 2019
@BenTheElder BenTheElder deleted the update-deps2 branch November 7, 2019 08:50
@BenTheElder
Copy link
Member Author

[bentheelder@bentheelder-macbookpro:~/go/src/sigs.k8s.io/kind·2019-11-07T01:40:49-0800·master@f56b2cb]
$ kind version
kind v0.6.0-alpha+f56b2cbad927a5 go1.13.4 darwin/amd64

[bentheelder@bentheelder-macbookpro:~/go/src/sigs.k8s.io/kind·2019-11-07T01:40:51-0800·master@f56b2cb]
$ du -h $(which kind)
8.8M    /Users/bentheelder/go/bin/kind

:-)

dropped another half megabyte somewhere in here as a side effect, nice bonus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants