Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect docker btrfs backend filesystem #2149

Merged
merged 1 commit into from Mar 23, 2021

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Mar 22, 2021

Fixes: #1945,#2050

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/docker Issues or PRs related to docker approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2021
@aojea
Copy link
Contributor Author

aojea commented Mar 22, 2021

/assign @BenTheElder
@anfredette can you please verify this solves the issue for fedora33?

Copy link

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running on a fresh install of Fedora 33 Workstation in which btrfs replaced ext4 as the default filesystem.

kind was failing to start with the following error:
ERROR: failed to create cluster: failed to init node with kubeadm: command "docker exec --privileged ovn-control-plane kubeadm init --skip-phases=preflight --config=/kind/kubeadm.conf --skip-token-print --v=6" failed with error: exit status 1

For reference:
$ docker info --format='{{ index (index .DriverStatus 0) 1 }}'
btrfs

This change fixes my issue.

@k8s-ci-robot
Copy link
Contributor

@anfredette: changing LGTM is restricted to collaborators

In response to this:

I'm running on a fresh install of Fedora 33 Workstation in which btrfs replaced ext4 as the default filesystem.

kind was failing to start with the following error:
ERROR: failed to create cluster: failed to init node with kubeadm: command "docker exec --privileged ovn-control-plane kubeadm init --skip-phases=preflight --config=/kind/kubeadm.conf --skip-token-print --v=6" failed with error: exit status 1

For reference:
$ docker info --format='{{ index (index .DriverStatus 0) 1 }}'
btrfs

This change fixes my issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Contributor Author

aojea commented Mar 22, 2021

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2021
@aojea
Copy link
Contributor Author

aojea commented Mar 22, 2021

/retest

1 similar comment
@aojea
Copy link
Contributor Author

aojea commented Mar 22, 2021

/retest

@BenTheElder
Copy link
Member

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anfredette, aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/docker Issues or PRs related to docker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants