New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli: add the cluster name to the error message #2364
Cli: add the cluster name to the error message #2364
Conversation
- When you ask for a kubeconfig file for a named cluster (i..e not the default "kind"), instead of getting the (cryptic) message: "could not locate any control plane nodes", also return the name of the cluster, and a hint to what the user should maybe supply (the --name option). - Note: Did not find any existing tests for this file, nor which mock libraries we should use to mock the dependencies? Testing Done: Create a named cluster and tested the `get kubeconfig` option: ``` $ make build unit verify $ ./bin/kind create cluster --name mytest $ ./bin/kind get kubeconfig ERROR: could not locate any control plane nodes for cluster named 'kind'. Use the --name option to select a different cluster $ ./bin/kind get kubeconfig --name mytest apiVersion: v1 clusters: - cluster: certificate-authority-data: LS0tLS[...] ``` Bug Number: kubernetes-sigs#2205
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @fstrudel! |
Hi @fstrudel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fstrudel you have to sign the CLA |
/check-cla |
/retest |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, fstrudel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cluster (i..e not the default "kind"), instead of
getting the (cryptic) message:
"could not locate any control plane nodes",
also return the name of the cluster, and a hint
to what the user should maybe supply (the --name
option).
libraries we should use to mock the dependencies?
Testing Done: Create a named cluster and tested the
get kubeconfig
option:Bug Number: #2205