podman-provider: get actually available cgroupControllers

[flouthoc]

Hi Team,

Following (containers/podman#10387) got rolled out in multiple versions. I think we can remove the hard-codes.

[k8s-ci-robot]

Welcome @flouthoc!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @flouthoc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

Hi Team,

Following (containers/podman#10387) got rolled out in multiple versions. I think we can remove the hard-codes.

that patch seems to affect only 3.3.0 and onwards, what happen with 3.2.0 and previous versions?

[flouthoc]

@aojea I dont think it will be backported. Marking PR as draft till we get confirmation on previous versions.

[aojea]

let's run it through the CI, I know we have some checks for the podman version, I'll take a look later this week
/ok-to-test
/assign

[BenTheElder]

@aojea you have to click "approve and run" to run github actions, prow does not run podman and does not trigger github actions

[BenTheElder]

Following (containers/podman#10387) got rolled out in multiple versions. I think we can remove the hard-codes.

what versions?
what about the previous versions we supported? are they widely installed?

[AkihiroSuda]

This only makes sense for Podman v4: containers/podman#11935

For Podman v3 we can't rely on podman info (unless
containers/podman#11935 gets backported to v3)

[flouthoc]

@AkihiroSuda makes sense since i don't think it will be backported. Should let the PR dangle in draft mode or close ?

[AkihiroSuda]

@AkihiroSuda makes sense since i don't think it will be backported. Should let the PR dangle in draft mode or close ?

Maybe parse Podman version, and apply the new logic only when the version is newer than 4.0.0 ?

[aojea]

@AkihiroSuda makes sense since i don't think it will be backported. Should let the PR dangle in draft mode or close ?

Maybe parse Podman version, and apply the new logic only when the version is newer than 4.0.0 ?

there are already some helpers

kind/pkg/cluster/internal/providers/podman/provider.go

Lines 184 to 192 in dbe461f

	// TODO: get rid of this once podman settles on how to get the port mapping using podman inspect
	// This is only used to get the Kubeconfig server field
	v, err := getPodmanVersion()
	if err != nil {
	return "", errors.Wrap(err, "failed to check podman version")
	}
	// podman inspect was broken between 2.2.0 and 3.0.0
	// https://github.com/containers/podman/issues/8444
	if v.AtLeast(version.MustParseSemantic("2.2.0")) &&

[flouthoc]

@aojea @AkihiroSuda thanks for the suggestion made changes PTAL :)

[aojea]

/lgtm
/approve
Thanks

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, aojea, flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cluster/internal/providers/podman/OWNERS [aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment