Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: update Fedora to 35 #2559

Merged
merged 2 commits into from Dec 16, 2021
Merged

CI: update Fedora to 35 #2559

merged 2 commits into from Dec 16, 2021

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Dec 2, 2021 •
edited

@AkihiroSuda
CI: update Fedora to 35
81b392d 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2021
@AkihiroSuda
rootless: set LocalStorageCapacityIsolation=false to avoid "could not…
ab38ef8 
… find device ..." error

For avoiding err="failed to get rootfs info: failed to get device for dir \"/var/lib/kubelet\": could not find device with major: 0, minor: 41 in cached partitions map"

Fix issue 2524

See https://github.com/kubernetes/kubernetes/blob/v1.22.2/pkg/kubelet/cm/container_manager_linux.go#L641-L649

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2021
@aojea
Copy link
Contributor

aojea commented Dec 2, 2021

does this mean that most fedora users has to enable this feature gate for podman rootless?
#2524 (comment)

@AkihiroSuda
Copy link
Member Author

does this mean that most fedora users has to enable this feature gate for podman rootless?

Yes, probably

This was referenced Dec 15, 2021
Closed
Closed
@aojea
Copy link
Contributor

aojea commented Dec 15, 2021

/lgtm
@BenTheElder for approval, I can't find a better solution than this, no ideal , but at least is constrained to rootless that we mark as experimental

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2021
@aojea aojea assigned BenTheElder and unassigned aojea Dec 15, 2021
@aojea
Copy link
Contributor

aojea commented Dec 16, 2021

/approve
This is contained under a flag for rootless

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit c88b8ec into kubernetes-sigs:main Dec 16, 2021
@BenTheElder BenTheElder mentioned this pull request Jul 1, 2022
Closed
@vially vially mentioned this pull request Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@amwat amwat Awaiting requested review from amwat

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AkihiroSuda @aojea @k8s-ci-robot @BenTheElder