Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance "kind delete cluster(s)" command #3074

Closed
wants to merge 1 commit into from

Conversation

yuanchen8911
Copy link
Member

@yuanchen8911 yuanchen8911 commented Jan 19, 2023

Why?

kind delete cluster(s) command doesn't report any error if the cluster(s) to be deleted doesn't exist. The output can be misleading.

What?

Check if the cluster(s) to be deleted exist or not. If it doesn't exist, report an error `cluster xxx doesn't exist"

Example

Current version:

$ kind delete clusters non-existing-cluster
Deleted clusters: ["non-existing-cluster"]

New version:

$ kind delete clusters non-existing-cluster
failed to delete cluster "non-existing-cluster": cluster "non-existing-cluster" doesn't exist
Deleted clusters: []

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuanchen8911
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval by writing /assign @bentheelder in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2023
@aojea
Copy link
Contributor

aojea commented Jan 19, 2023

This is on purpose, I'm from mobile right now but there should be some issue or or explaining this decision

@k8s-ci-robot
Copy link
Contributor

@yuanchen8911: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kind-e2e-kubernetes-1-24 0c00ecf link true /test pull-kind-e2e-kubernetes-1-24

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuanchen8911
Copy link
Member Author

/retest

@BenTheElder
Copy link
Member

this is a breaking change we will not be accepting, with past discussions in the issue tracker e.g. #2924

kind delete cluster(s) is like rm -f, for use re-entrantly in scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants