Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error if host-ports are configured again with same listen address and protocol #3175

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Raise error if host-ports are configured again with same listen address and protocol #3175

merged 1 commit into from
Apr 29, 2023

Conversation

aroradaman
Copy link
Member

fixes #2975

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/docker Issues or PRs related to docker labels Apr 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2023
BenTheElder
BenTheElder reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'm going to defer to antonio as the real networking expert :-)

@aojea
Copy link
Contributor

aojea commented Apr 29, 2023

almost there, one last comment

@aroradaman
pkg/cluster: raise error if host-ports are configured again with same…
8c1e47a 
… addr and protocol

Signed-off-by: Daman <aroradaman@gmail.com>
@aojea
Copy link
Contributor

aojea commented Apr 29, 2023

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, daman1807

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit b9d362c into kubernetes-sigs:main Apr 29, 2023
14 checks passed
@prahaladramji prahaladramji mentioned this pull request Jul 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@aojea aojea aojea left review comments

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/docker Issues or PRs related to docker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate that hostports are not configured twice with the same protocol
5 participants
@aroradaman @aojea @k8s-ci-robot @neolit123 @BenTheElder