Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kindnetd mod #3608

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

BenTheElder
Copy link
Member

builds on #3607

bring kindnetd to more current client etc.

TODO: switch to 1.30, after we resolve upgrading to go1.22

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2024
images/kindnetd/go.mod Outdated Show resolved Hide resolved
…ssue 4233)

bump coreos/go-iptables to v0.7.0
@BenTheElder BenTheElder added this to the v0.23.0 milestone May 13, 2024
@aojea
Copy link
Contributor

aojea commented May 13, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 13, 2024

@BenTheElder: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kind-e2e-kubernetes-1-27 96a3352 link true /test pull-kind-e2e-kubernetes-1-27
pull-kind-e2e-kubernetes-1-28 96a3352 link true /test pull-kind-e2e-kubernetes-1-28

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BenTheElder
Copy link
Member Author

NFS tests failing all over ...
will check against another PR

@BenTheElder
Copy link
Member Author

#648 (comment)

@BenTheElder
Copy link
Member Author

Output: mount.nfs: Protocol not supported

we saw this the other day in this thread https://kubernetes.slack.com/archives/C09QZ4DQB/p1714646180463719

@BenTheElder
Copy link
Member Author

@BenTheElder
Copy link
Member Author

/retest

@BenTheElder
Copy link
Member Author

#3609

@BenTheElder
Copy link
Member Author

Same NFS test issues in no-op PR, #648 (comment)

bypassing these, and talked to dims about backporting the test fix.

@BenTheElder BenTheElder merged commit 4a36b22 into kubernetes-sigs:main May 13, 2024
26 of 29 checks passed
@BenTheElder BenTheElder deleted the bump-kindnetd-mod branch May 13, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants