Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to currently supported fedora #3654

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Jun 11, 2024

stop hardcoding exact download

xref #3653

/hold

TODO: figure out why fedora 40 isn't working

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2024
@stmcginnis
Copy link
Contributor

#3653 is good, but I kind of think it might be good to just make the bigger jump while we're at it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@BenTheElder
Copy link
Member Author

/override pull-kind-e2e-kubernetes-1-29

pod scheduling timeout in prow is not great but also not relevant to this PR

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-kind-e2e-kubernetes-1-29

In response to this:

/override pull-kind-e2e-kubernetes-1-29

pod scheduling timeout in prow is not great but also not relevant to this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder
Copy link
Member Author

This change isn't working yet.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@BenTheElder
Copy link
Member Author

Looks like Fedora 39 works. It's still supported but 40 would be more current.

It also looks like the downloads are slow and we should switch back to downloading from a mirror.

@stmcginnis
Copy link
Contributor

Just capturing failure message here for convenience and in case we lose the job logs.

Pod "pfpod2" is invalid: [spec.containers[0].resources.requests: Invalid value: "600m": must be less than or equal to cpu limit of 500m, spec.containers[0].resources.requests: Invalid value: "600Gi": must be less than or equal to ephemeral-storage limit of 500Gi, spec.containers[0].resources.requests: Invalid value: "600Mi": must be less than or equal to memory limit of 500Mi]

@BenTheElder
Copy link
Member Author

So that's a bug in the upstream tests and we should file an issue there, it's defintiely not related to this PR which only affects some of the github actions.

@BenTheElder BenTheElder changed the title switch to current fedora (40) switch to currently supported fedora Jun 20, 2024
@BenTheElder
Copy link
Member Author

/override pull-kind-e2e-kubernetes-1-26 pull-kind-e2e-kubernetes-1-27

(prow e2e not relevant for this change)

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Overrode contexts on behalf of BenTheElder: pull-kind-e2e-kubernetes-1-26, pull-kind-e2e-kubernetes-1-27

In response to this:

/override pull-kind-e2e-kubernetes-1-26 pull-kind-e2e-kubernetes-1-27

(prow e2e not relevant for this change)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder
Copy link
Member Author

actions are passing, I lost context and I can't see how to pull up older runs easily on github for comparison, so I'm not sure if the download is faster but it seems sufficiently fast.

@BenTheElder
Copy link
Member Author

/hold-cancel

@stmcginnis
Copy link
Contributor

actions are passing, I lost context and I can't see how to pull up older runs easily on github for comparison, so I'm not sure if the download is faster but it seems sufficiently fast.

Looking under the Actions tab, I took a look at this and past runs.

The current VM/CGroupv2 runs took anywhere between 5:37 and 5.51 for the "Boot Fedora" step.

The same jobs with the "e2e-k8s.sh: support --ginkgo.label-filter" PR took between 4:35 and 5:43.

So very slightly more time with the newer Fedora, but that image is probably very slightly larger than the older one anyway. That seems reasonable to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 20, 2024

@BenTheElder: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kind-conformance-parallel-ipv6 0ff901d link true /test pull-kind-conformance-parallel-ipv6
pull-kind-e2e-kubernetes-1-29 0ff901d link true /test pull-kind-e2e-kubernetes-1-29

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@BenTheElder BenTheElder merged commit 7284cbc into kubernetes-sigs:main Jun 20, 2024
26 of 29 checks passed
@BenTheElder BenTheElder deleted the update-fedora branch June 20, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants