[WIP] log untar errors #992
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
size/S
|
/test all |
| @@ -130,6 +129,11 @@ func Collect(nodes []nodes.Node, dir string) error { | |||
| // untar reads the tar file from r and writes it into dir. | |||
| func untar(r io.Reader, dir string) (err error) { | |||
| tr := tar.NewReader(r) | |||
| defer func() { | |||
There was a problem hiding this comment.
is this really needed? is is possible this func returns without error?
There was a problem hiding this comment.
The WIP is to prevent merge. This PR is just being used to obtain debugging information versus trying to trigger this failure mode locally because CI will run many jobs at once for me :-)
There was a problem hiding this comment.
(also that's why it checks if err != nil)
|
/test all |
1 similar comment
|
/test all |
|
/test all |
|
/test all |
7 similar comments
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/retest |
|
/test all |
1 similar comment
|
/test all |
|
/test all |
3 similar comments
|
/test all |
|
/test all |
|
/test all |
|
/test all |
2 similar comments
|
/test all |
|
/test all |
|
Why is the pipe closed? |
xref: #949 (comment)