Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: plugin doctor to 0.3.1 #2243

Closed
wants to merge 2 commits into from
Closed

update: plugin doctor to 0.3.1 #2243

wants to merge 2 commits into from

Conversation

sid-maddy
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2022
@ahmetb
Copy link
Member

ahmetb commented May 9, 2022

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/doctor.yaml is not a straightforward version bump: changing old version ("0.3.0") with new version ("0.3.1") in the url (https://github.com/emirozer/kubectl-doctor/releases/download/0.3.0/kubectl-doctor_darwin_amd64.zip) does not appear in the patch as https://github.com/emirozer/kubectl-doctor/releases/download/0.3.1/kubectl-doctor_darwin_amd64.zip
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the kind/plugin-update Version or manifest updates for existing plugins label May 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @sid-maddy!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from ahmetb May 9, 2022 10:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sid-maddy
To complete the pull request process, please assign corneliusweig after the PR has been reviewed.
You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2022
@ahmetb
Copy link
Member

ahmetb commented May 9, 2022

The tests are failing

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2022
@sid-maddy
Copy link
Author

From what I can tell, krew expects an archive, which this release of kubectl-doctor doesn't have. I suppose I'll just raise an issue there to add the assets as archives.

@ahmetb
Copy link
Member

ahmetb commented May 11, 2022

@sid-maddy That's awkward.
We expect plugin authors to know that their plugin is distributed here, and own the automated release process.
It would be great if you can get the plugin author on board to set up Krew release automation and document Krew installation method in the plugin repo as well. :)

@ahmetb
Copy link
Member

ahmetb commented May 17, 2022

/close

@k8s-ci-robot
Copy link
Contributor

@ahmetb: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants