-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds fleet plugin #365
adds fleet plugin #365
Conversation
This plugin is mainly targeted at infra ops, dealing with multiple clusters. It's written in Go, has no dependencies and is based off of `replicatedhq/krew-plugin-template`. Note: only tested with macOS and Linux.
Welcome @mhausenblas! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhausenblas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @corneliusweig |
adds license and expands on description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this nice utility to the index!
I can go ahead and merge, but I want to give you the chance to boil the shortDescription
down a little more. Just let me know if you want to do it now or later.
@mhausenblas The size limit is only documented as a comment in https://github.com/kubernetes-sigs/krew/blob/master/docs/DEVELOPER_GUIDE.md#writing-a-plugin-manifest. As there is no hard enforcement, we simply remind plugin authors about what will work best. Fyi, there has been a PR (kubernetes-sigs/krew#302) to enforce this, but there was no consensus so I dropped it. |
Thanks for the clarification re the limit @corneliusweig! Is there anything else or can this PR now be merged? |
You need to amend your commit history to remove @ mention. |
Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Ah damn, my Git foo was too weak, starting over again :( |
This plugin is mainly targeted at infra ops, dealing with multiple clusters. It's written in Go, has no dependencies and is based off of
replicatedhq/krew-plugin-template
. Note: only tested with macOS and Linux.