Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds fleet plugin #365

Closed
wants to merge 6 commits into from
Closed

adds fleet plugin #365

wants to merge 6 commits into from

Conversation

mhausenblas
Copy link
Contributor

This plugin is mainly targeted at infra ops, dealing with multiple clusters. It's written in Go, has no dependencies and is based off of replicatedhq/krew-plugin-template. Note: only tested with macOS and Linux.

This plugin is mainly targeted at infra ops, dealing with multiple clusters. It's written in Go, has no dependencies and is based off of `replicatedhq/krew-plugin-template`. Note: only tested with macOS and Linux.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @mhausenblas!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhausenblas
To complete the pull request process, please assign corneliusweig
You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 29, 2019
@mhausenblas
Copy link
Contributor Author

/assign @corneliusweig

plugins/fleet.yaml Outdated Show resolved Hide resolved
adds license and expands on description
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 1, 2019
Copy link
Contributor

@corneliusweig corneliusweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this nice utility to the index!

I can go ahead and merge, but I want to give you the chance to boil the shortDescription down a little more. Just let me know if you want to do it now or later.

plugins/fleet.yaml Show resolved Hide resolved
plugins/fleet.yaml Outdated Show resolved Hide resolved
@corneliusweig
Copy link
Contributor

@mhausenblas The size limit is only documented as a comment in https://github.com/kubernetes-sigs/krew/blob/master/docs/DEVELOPER_GUIDE.md#writing-a-plugin-manifest. As there is no hard enforcement, we simply remind plugin authors about what will work best.

Fyi, there has been a PR (kubernetes-sigs/krew#302) to enforce this, but there was no consensus so I dropped it.

@mhausenblas
Copy link
Contributor Author

Thanks for the clarification re the limit @corneliusweig! Is there anything else or can this PR now be merged?

@ahmetb
Copy link
Member

ahmetb commented Dec 2, 2019

Is there anything else or can this PR now be merged?

You need to amend your commit history to remove @ mention.

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mhausenblas
Copy link
Contributor Author

Ah damn, my Git foo was too weak, starting over again :(

@mhausenblas mhausenblas closed this Dec 4, 2019
@mhausenblas mhausenblas deleted the fleet branch December 4, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants