Be consistent with the number of lines

0 plugins -> empty string (instead of 2 lines) 1 plugin -> 1 line (instead of 2 lines) 2 plugins -> 2 lines (instead of 3 lines)
kubernetes-sigs · Jun 10, 2019 · 356a9ee · 356a9ee
1 parent 44fdfb4
commit 356a9ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/cmd/krew/cmd/list.go b/cmd/krew/cmd/list.go
@@ -51,7 +51,7 @@ Remarks:
 					names = append(names, name)
 				}
 				sort.Strings(names)
-				fmt.Fprintln(os.Stdout, strings.Join(names, "\n"))
+				fmt.Fprint(os.Stdout, strings.Join(names, "\n"))
 				return nil
 			}
 

diff --git a/test/krew_test.go b/test/krew_test.go
@@ -162,6 +162,7 @@ func TestKrewUpdate(t *testing.T) {
 	test, cleanup := krew.NewTest(t)
 	defer cleanup()
 
+	// nb do not call WithIndex() here
 	test.Krew("update").RunOrFail()
 	plugins := lines(test.Krew("search").RunOrFailOutput())
 	if len(plugins) < 10 {