Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Installing an additional executable for plugin's completion script #812

Open
predatorray opened this issue Nov 8, 2022 · 7 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@predatorray
Copy link

Hi there, I am the maintainer of a krew plugin. Kubectl recently released a new feature to support shell completion for plugins in its latest alpha release v1.26.0-alpha.3. It requires an additional executable named kubectl_complete-<pluginName> present on $PATH.

As discussed in the pull request, krew does not provide a way to deliver this separate executable because bin: in the manifest yaml only expects one parameter. As a result, although I have implemented the completion script and managed to publish it to a homebrew tap simply by adding another bin.install (see: predatorray/homebrew-brew#5), I am still not able to release this feature to the users using krew.

I am wondering do we have any plan to support this feature, for example, by supporting multiple parameters under bin: or providing another parameter called completion?

@ahmetb
Copy link
Member

ahmetb commented Nov 8, 2022

Yeah we should add support. I wasn't aware kubectl implemented support for it, as it was mostly in design discussion phase. It may take a while for us to get this done, so please be patient. Design proposals for this are appreciated.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 6, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 8, 2023
@ahmetb
Copy link
Member

ahmetb commented Mar 8, 2023

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 8, 2023
@chisaato
Copy link

Here are some workaound for zsh users before this complete.

#810 (comment)

@fredgate
Copy link

krew knows the name of the plugin. Couldn't it automatically copy the kubectl_complete-pluginname file into the PATH if there is one in the plugin package ?

@marckhouzam
Copy link

Until this is supported by krew and that plugins make use of it, people can use the following little project to generate the required completion script for about 50% of plugins installed by krew: https://github.com/marckhouzam/kubectl-plugin_completion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

7 participants