Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Stop relying setting RemoveSelfLink=false feature-gate - we're locking it to true with GA graduation in 1.24 #958

Closed
wojtek-t opened this issue Jan 10, 2022 · 4 comments

Comments

@wojtek-t
Copy link

wojtek-t commented Jan 10, 2022

Upstream Kubernetes is going to get rid of ability to set SelfLink in release 1.24 (basically graduate graduate RemoveSelfLink feature gate to stable - see the KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1164-remove-selflink, for a bit more details).

It seems that kube-batch is still vendoring Kubernetes version that is setting it to false:
https://github.com/kubernetes-sigs/kube-batch/blob/master/vendor/k8s.io/apiserver/pkg/features/kube_features.go#L141

This is one more heads'up to stop relying on it (if you do in any place).

@warmchang
Copy link

typo: volcano --> kube-batch.

@wojtek-t
Copy link
Author

Sure - fixed

@ArangoGutierrez
Copy link

/close

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants