Add some docs for the extenders and export/import #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/simulator
k8s-ci-robot
added
the
sig/scheduling
k8s-ci-robot
added
approved
196Ikuchil
force-pushed
the
add_docs_snapshot_extender
branch
from
8f2f23b
to
9b0d8d7
Compare
k8s-ci-robot
added
size/L
sanposhiho
reviewed
May 20, 2023
simulator/docs/extender.md
Outdated
Comment on lines
11
to
13
| Note: This function uses api-server on the simulator to store the results. | ||
| Therefore, **if the scheduler is not connected to the simulator's api-server, | ||
| this feature is not available.** |
There was a problem hiding this comment.
I don't get it. Can you elaborate?
There was a problem hiding this comment.
Note: This feature is not available in [external scheduler](./external-scheduler.md).
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
Co-authored-by: Kensei Nakada <handbomusic@gmail.com>
|
Thanks! |
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 196Ikuchil, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area simulator
/kind documentation
What this PR does / why we need it:
Due to lack of documentation on these features.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/label tide/merge-method-squash