Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: create the doc for the debuggable scheduler #301

Merged
merged 3 commits into from
Jun 25, 2023
Merged

doc: create the doc for the debuggable scheduler #301

merged 3 commits into from
Jun 25, 2023

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented May 1, 2023 •
edited
Loading

What type of PR is this?

/area simulator
/kind cleanup
/kind documentation

What this PR does / why we need it:

  • rename externalscheduler package to debuggablescheduler package.
  • add the doc to describe the debuggable scheduler.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added area/simulator Issues or PRs related to the simulator. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2023
@k8s-ci-robot
Copy link
Contributor

@sanposhiho: The label(s) kind/(breaking, kind/change, kind/of, kind/renaming, kind/the, kind/package.) cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/area simulator
/kind cleanup
/kind documentation
/kind api-change (breaking change of renaming the package.)

What this PR does / why we need it:

  • rename externalscheduler package to debuggablescheduler package.
  • add the doc to describe the debuggable scheduler.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 1, 2023
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 1, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2023
@sanposhiho
Copy link
Member Author

/remove-kind api-change

@k8s-ci-robot k8s-ci-robot removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 1, 2023
196Ikuchil
196Ikuchil reviewed May 6, 2023
View reviewed changes
Copy link
Contributor

@196Ikuchil 196Ikuchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some small nits🙏

simulator/pkg/debuggablescheduler/debuggable_scheduler.go Show resolved Hide resolved
simulator/pkg/debuggablescheduler/debuggable_scheduler.go Show resolved Hide resolved
@sanposhiho
Copy link
Member Author

I'll give an update after #302

@sanposhiho
Copy link
Member Author

@196Ikuchil Updated!

196Ikuchil
196Ikuchil approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@196Ikuchil 196Ikuchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanposhiho
Looks good 🚀

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 25, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 25, 2023
@sanposhiho
Copy link
Member Author

rebased 👌

196Ikuchil
196Ikuchil reviewed Jun 25, 2023
View reviewed changes
Copy link
Contributor

@196Ikuchil 196Ikuchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanposhiho
🙏

README.md Outdated Show resolved Hide resolved
196Ikuchil
196Ikuchil approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@196Ikuchil 196Ikuchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 196Ikuchil, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [196Ikuchil,sanposhiho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bba1f66 into kubernetes-sigs:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@196Ikuchil 196Ikuchil 196Ikuchil approved these changes

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@196Ikuchil 196Ikuchil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/simulator Issues or PRs related to the simulator. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanposhiho @k8s-ci-robot @196Ikuchil