-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade Kubernetes version to v0.28.5 #329
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @196Ikuchil @utam0k |
It seems you should replace
I'm pleased to review this PR, so please let me know when it becomes ready. |
be1da20
to
d9b9dde
Compare
/retest |
1 similar comment
/retest |
Well, why is the linting job endless. |
/retest |
@@ -5,7 +5,7 @@ generate: | |||
|
|||
.PHONY: lint | |||
lint: | |||
golangci-lint run --timeout 30m ./... | |||
golangci-lint run --timeout 90m ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that we had 30min timeout, but nonetheless, the job had been running for more than 30 min (and eventually evicted).
Here, I increased the timeout, plus let's increase the resource for the job a bit: kubernetes/test-infra#31626
/retest |
It took me a thousand years, finally the linter issue is somehow resolved by changing the way to install golangci-lint 🤷 . |
/lgtm Thanks |
What type of PR is this?
/area simulator
/kind feature
What this PR does / why we need it:
upgrade Kubernetes version to v0.28.5.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/label tide/merge-method-squash