Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Kubernetes version to v0.28.5 #329

Merged
merged 5 commits into from
Jan 23, 2024
Merged

upgrade Kubernetes version to v0.28.5 #329

merged 5 commits into from
Jan 23, 2024

Conversation

sanposhiho
Copy link
Member

What type of PR is this?

/area simulator
/kind feature

What this PR does / why we need it:

upgrade Kubernetes version to v0.28.5.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added area/simulator Issues or PRs related to the simulator. kind/feature Categorizes issue or PR as related to a new feature. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@sanposhiho
Copy link
Member Author

/cc @196Ikuchil @utam0k

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 10, 2024
@utam0k
Copy link
Member

utam0k commented Jan 10, 2024

It seems you should replace sets.String with sets.Set. ref: kubernetes/kubernetes#113709

scheduler/plugin/wrappedplugin_test.go:1295:49: cannot use sets.NewString("hoge") (value of type sets.String) as sets.Set[string] value in struct literal (typecheck)
			want:  &framework.PreFilterResult{NodeNames: sets.NewString("hoge")},

I'm pleased to review this PR, so please let me know when it becomes ready.

@sanposhiho
Copy link
Member Author

kubernetes/test-infra#31621 😮‍💨

@sanposhiho
Copy link
Member Author

/retest

1 similar comment
@sanposhiho
Copy link
Member Author

/retest

@sanposhiho
Copy link
Member Author

Well, why is the linting job endless.

@sanposhiho
Copy link
Member Author

/retest

@@ -5,7 +5,7 @@ generate:

.PHONY: lint
lint:
golangci-lint run --timeout 30m ./...
golangci-lint run --timeout 90m ./...
Copy link
Member Author

@sanposhiho sanposhiho Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that we had 30min timeout, but nonetheless, the job had been running for more than 30 min (and eventually evicted).
Here, I increased the timeout, plus let's increase the resource for the job a bit: kubernetes/test-infra#31626

@sanposhiho
Copy link
Member Author

/retest

@sanposhiho
Copy link
Member Author

It took me a thousand years, finally the linter issue is somehow resolved by changing the way to install golangci-lint 🤷 .
@utam0k @196Ikuchil Give it /lgtm when get a chance.

@utam0k
Copy link
Member

utam0k commented Jan 23, 2024

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit c8491d1 into master Jan 23, 2024
5 checks passed
@sanposhiho sanposhiho deleted the upversion branch February 18, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/simulator Issues or PRs related to the simulator. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants