-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PrefilterExtensions #92
Support PrefilterExtensions #92
Conversation
Welcome @chansuke! |
c4bf036
to
f1a2217
Compare
@sanposhiho /assign |
/assign @sanposhiho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Thanks! Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good!
I left several minor comments.
I will add approve comment if all ci checks can be passed.
Please fix ci failures. |
Yes, I will do this tonight🙏 |
y'all are on a roll! |
@chansuke |
/label tide/merge-method-squash |
@chansuke Please rebase it upon the latest master, that should be easy enough. |
@sanposhiho |
322ac6b
to
33e5087
Compare
a3775a3
to
68c6654
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chansuke, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
👏👏🎉🎉 |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Added
PrefilterExtensions
Which issue(s) this PR fixes:
Fixes part of #72
Special notes for your reviewer:
Does this PR introduce a user-facing change?
What are the benchmark results of this change?