Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PrefilterExtensions #92

Merged
merged 45 commits into from
Jul 14, 2024
Merged

Support PrefilterExtensions #92

merged 45 commits into from
Jul 14, 2024
+621 −21

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented Jan 2, 2024 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Added PrefilterExtensions

Which issue(s) this PR fixes:

Fixes part of #72

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support PrefilterExtensions

What are the benchmark results of this change?

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @chansuke!

It looks like this is your first PR to kubernetes-sigs/kube-scheduler-wasm-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kube-scheduler-wasm-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 2, 2024
@chansuke chansuke force-pushed the feature/add-pre-filter-extenssions branch 6 times, most recently from c4bf036 to f1a2217 Compare January 8, 2024 07:03
@chansuke chansuke changed the title WIP: Support PrefilterExtensions Support PrefilterExtensions Jan 8, 2024
@chansuke chansuke marked this pull request as ready for review January 8, 2024 07:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@chansuke
Copy link
Member Author

chansuke commented Jan 8, 2024

@sanposhiho
Thank you so much for the support.
I've added the PrefilterExtensions. PTAL.

/assign
/assign @sanposhiho

@chansuke
Copy link
Member Author

chansuke commented Jan 8, 2024

/assign @sanposhiho

@chansuke chansuke removed their assignment Jan 8, 2024
Gekko0114
Gekko0114 reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@Gekko0114 Gekko0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign
Thanks! Left some comments.

guest/prefilterextensions/prefilterextensions.go Outdated Show resolved Hide resolved
internal/e2e/e2e.go Outdated Show resolved Hide resolved
scheduler/plugin/guest.go Outdated Show resolved Hide resolved
scheduler/plugin/guest.go Outdated Show resolved Hide resolved
Gekko0114
Gekko0114 reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@Gekko0114 Gekko0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!
I left several minor comments.
I will add approve comment if all ci checks can be passed.

scheduler/plugin/plugin_test.go Outdated Show resolved Hide resolved
scheduler/plugin/plugin_test.go Outdated Show resolved Hide resolved
scheduler/plugin/plugin_test.go Outdated Show resolved Hide resolved
scheduler/plugin/plugin_test.go Outdated Show resolved Hide resolved
guest/prefilterextensions/prefilterextensions.go Outdated Show resolved Hide resolved
guest/prefilterextensions/prefilterextensions.go Outdated Show resolved Hide resolved
guest/prefilterextensions/prefilterextensions.go Outdated Show resolved Hide resolved
@Gekko0114
Copy link
Member

Please fix ci failures.

@chansuke
Copy link
Member Author

Yes, I will do this tonight🙏

@codefromthecrypt
Copy link
Contributor

y'all are on a roll!

@Gekko0114
Copy link
Member

@chansuke
Could you fix CI failure? Seems some of cases failed

@Gekko0114
Copy link
Member

/label tide/merge-method-squash

@sanposhiho
Copy link
Member

sanposhiho commented Jul 13, 2024 •
edited
Loading

@chansuke Please rebase it upon the latest master, that should be easy enough.
I think then we can make it merged soon. We're anyways at an early stage, any modification or refactoring can be made after merging.

@chansuke
Copy link
Member Author

@sanposhiho
Yes,will do.

@chansuke chansuke force-pushed the feature/add-pre-filter-extenssions branch from 322ac6b to 33e5087 Compare July 14, 2024 03:47
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2024
@chansuke chansuke force-pushed the feature/add-pre-filter-extenssions branch from a3775a3 to 68c6654 Compare July 14, 2024 04:06
@sanposhiho
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chansuke, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2024
@sanposhiho
Copy link
Member

👏👏🎉🎉

@k8s-ci-robot k8s-ci-robot merged commit fbddc96 into kubernetes-sigs:main Jul 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gekko0114 Gekko0114 Gekko0114 requested changes

@sanposhiho sanposhiho sanposhiho left review comments

@codefromthecrypt codefromthecrypt Awaiting requested review from codefromthecrypt

@kerthcet kerthcet Awaiting requested review from kerthcet

@evacchi evacchi Awaiting requested review from evacchi

Assignees

@Gekko0114 Gekko0114

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chansuke @k8s-ci-robot @Gekko0114 @codefromthecrypt @sanposhiho @evacchi