We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happened:
Validator expects empty lines before and after each document separator --- in the expected output manifests that I specify in "*.out.yaml".
---
#example.out.yaml apiVersion: v1 kind: Namespace metadata: name: x --- apiVersion: v1 kind: Namespace metadata: name: y
What you expected to happen:
I expected that I should be able to specify consecutive objects in my "*.out.yaml" file without the extra newlines.
How to reproduce it (as minimally and precisely as possible):
You can see that the existing guestbook test with validator
guestbook
validator
kubebuilder-declarative-pattern/examples/guestbook-operator/controllers/guestbook_controller_test.go
Line 27 in f6a5c89
expects newlines before and after each document separator
kubebuilder-declarative-pattern/examples/guestbook-operator/controllers/tests/patches-stable.out.yaml
Line 32 in f6a5c89
Anything else we need to know?:
This line
kubebuilder-declarative-pattern/pkg/test/golden/validator.go
Line 324 in f6a5c89
that adds additional newlines, even though yamilzer.Encode already adds a newline after the object, is likely the culprit.
The text was updated successfully, but these errors were encountered:
Fix kubernetes-sigs#360
f8a6178
Remove extra newlines between objects in test/validator manifest output.
Merge pull request #361 from annasong20/fix-validator-spacing
d7eaf43
Fix Validator output spacing #360
Successfully merging a pull request may close this issue.
What happened:
Validator expects empty lines before and after each document separator
---
in the expected output manifests that I specify in "*.out.yaml".What you expected to happen:
I expected that I should be able to specify consecutive objects in my "*.out.yaml" file without the extra newlines.
How to reproduce it (as minimally and precisely as possible):
You can see that the existing
guestbook
test withvalidator
kubebuilder-declarative-pattern/examples/guestbook-operator/controllers/guestbook_controller_test.go
Line 27 in f6a5c89
expects newlines before and after each document separator
kubebuilder-declarative-pattern/examples/guestbook-operator/controllers/tests/patches-stable.out.yaml
Line 32 in f6a5c89
Anything else we need to know?:
This line
kubebuilder-declarative-pattern/pkg/test/golden/validator.go
Line 324 in f6a5c89
that adds additional newlines, even though yamilzer.Encode already adds a newline after the object, is likely the culprit.
The text was updated successfully, but these errors were encountered: