Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Validator output spacing #360 #361

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix Validator output spacing #360 #361

merged 1 commit into from
Nov 27, 2023

Conversation

annasong20
Copy link
Contributor

Fixes #360 by removing extra newlines between objects in test/validator manifest output.

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #360.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 21, 2023
@annasong20
Fix test validator spacing
7c36d62 
Remove extra newlines between objects in test/validator manifest output.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2023
@annasong20
Copy link
Contributor Author

/cc @yuwenma @haiyanmeng

@justinsb
Copy link
Contributor

Thanks @annasong20

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit d7eaf43 into kubernetes-sigs:master Nov 27, 2023
6 checks passed
yuwenma
yuwenma reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@atoato88
Copy link
Contributor

Nice catch!
Thank you for posting PR!

@annasong20 annasong20 mentioned this pull request Nov 28, 2023
Closed
@annasong20 annasong20 deleted the fix-validator-spacing branch November 30, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma left review comments

@johnsonj johnsonj Awaiting requested review from johnsonj

@justinsb justinsb Awaiting requested review from justinsb

@haiyanmeng haiyanmeng Awaiting requested review from haiyanmeng

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator inserts extra newlines between Objects
5 participants
@annasong20 @justinsb @k8s-ci-robot @atoato88 @yuwenma