Emit Reconciliation Metrics

[johnsonj]

A user should be able to emit metrics on the Prometheus metrics endpoint. Metrics should be written to the controller-runtime Prometheus Registry

The library should emit a metric for:

• P1: How many times in the last X seconds has reconciliation happened? How many times has it failed? 

  • Implement as two CounterVec metrics. ReconcileCount, ReconcileFailedCount. Use labels that identify the object type (eg CoreDNS) and namespace/name. These can be directly defined in reconciler.go

• P2: How many objects (and what type) are being managed by the operator?

  • Unclear how to implement this. A GaugeVec (with type/namespace/name labels) may work for this if the reconciler can keep track which types are created/destroyed.

/cc @annp1987

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[johnsonj]

/remove-lifecycle stale

…

On Sun, Mar 1, 2020 at 3:02 PM fejta-bot ***@***.***> wrote: Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Send feedback to sig-testing, kubernetes/test-infra and/or fejta <https://github.com/fejta>. /lifecycle stale — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#65?email_source=notifications&email_token=AADGRZKFFOD3MQ7EGBSPV4DRFLSPTA5CNFSM4JULRVHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNOKSI#issuecomment-593159497>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADGRZPP5CJ64ZXI4UQYJBDRFLSPTANCNFSM4JULRVHA> .

[vanou]

I'll take it.
/assign

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[vanou]

/remove-lifecycle stale

[vanou]

I think this issue got closed.
/close

[k8s-ci-robot]

@vanou: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

I think this issue got closed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[atoato88]

Thank you to deal this.
I think so too.
/close

[k8s-ci-robot]

@atoato88: Closing this issue.

In response to this:

Thank you to deal this.
I think so too.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.