Cherry-pick #361 and master flake fixes to release-0.13 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not doing so makes it harder to build options outside of the call, because we can't declare a []reconcilerOption unless it is exported.
The SMD library has a lot of the logic of server-side-apply (and more!) that we can reuse here. Co-authored-by: Antoine Pelisse <apelisse@gmail.com>
Generated using makefile, which extracts it from the k/k repo.
…roption Export ReconcilerOption
This enables us to test full controllers very easily, including the exact requests we make.
…ller Create test reconciler and capture http requests
mockkubeapiserver: add test using SMD library
We now get status updates and fieldmanagers in our mockkubeapiserver tests!
go.mod: Update internal packages
In theory a breaking change, but should not break anyone and avoids reparsing and confusion over JSON vs YAML input formats.
We generate a metadata file that includes the additional type information we need.
This reverts commit 6fd780e.
…hitelist Prune whitelist
Co-authored-by: Justin Santa Barbara <justinsb@google.com>
We lost the default value in kubernetes-sigs#247, which is a regression that prevents some changes from going through.
Add AddAnnotations companion to AddLabels
Set Overwrite in ApplyOptions
…_strings Change ApplierOptions to take Objects, not a manifest.
As of Go 1.16, funcs related to operate files and directories in the ioutil pakage are deprecated. This commit replaces deprecated funcs on ioutil by using io and os packages.
…d-ioutil-funcs Replace deprecated funcs on ioutil package
commonclient contains wrappers around functions we use from controller-runtime which have changed between 0.11 and 0.15 (the version range we are supporting currently). This allows for buildtags to be used to select a previous version of controller-runtime, without needing to carry patches.
Create abstraction layer over controller-runtime/client-go versions
A comparable change is being made in kubectl also; kind is clearer for end-users, and this enables creation of a CRD and an instance of the CRD in one applyset.
applyset: Switch to contains-group-kinds annotation
As suggested in prior code review.
Cleanup: remove commented-out code in kubectl fork
move applylib/third_party/forked to applylib/forked
remove dup imports
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: annasong20 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
Remove extra newlines between objects in test/validator manifest output.
annasong20
force-pushed
the
pick-newline-commit
branch
from
34a55ef
to
f179bcd
Compare
k8s-ci-robot
added
size/XXL
annasong20
changed the title
|
/lgtm Thank you, Anna. |
k8s-ci-robot
added
the
lgtm
|
/cc @haiyanmeng |
|
@annasong20: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR cherry-picks #361 to the release-0.13 branch. Because the current release-0.13 branch doesn't have the commits that fix the flaky tests, this PR also cherry-picks all commits up to 8f5c459.
This PR allows users to consume #361 in environments that cannot update their
sigs.k8s.io/controller-runtimeversion pastv0.15.0.Additional information
I didn't create this PR against
release-0.15branch because the tip of that branch is onv0.15.2ofsigs.k8s.io/controller-runtime, which my environment cannot update to yet.