Merge pull request #3468 from camilamacedo86/test-e2e-add

🌱 Adding checks to e2e tests to verify make manifest and generate command
kubernetes-sigs · Jun 20, 2023 · 3a3d1d9 · 3a3d1d9
2 parents 660671c + f7d980d
commit 3a3d1d9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/test/e2e/deployimage/plugin_cluster_test.go b/test/e2e/deployimage/plugin_cluster_test.go
@@ -159,14 +159,18 @@ func Run(kbc *utils.TestContext) {
 	err = kbc.Tidy()
 	ExpectWithOffset(1, err).NotTo(HaveOccurred())
 
-	By("run make all")
-	err = kbc.Make("all")
-	ExpectWithOffset(1, err).NotTo(HaveOccurred())
-
 	By("run make manifests")
 	err = kbc.Make("manifests")
 	ExpectWithOffset(1, err).NotTo(HaveOccurred())
 
+	By("run make generate")
+	err = kbc.Make("generate")
+	ExpectWithOffset(1, err).NotTo(HaveOccurred())
+
+	By("run make all")
+	err = kbc.Make("all")
+	ExpectWithOffset(1, err).NotTo(HaveOccurred())
+
 	By("run make install")
 	err = kbc.Make("install")
 	ExpectWithOffset(1, err).NotTo(HaveOccurred())

diff --git a/test/e2e/v4/plugin_cluster_test.go b/test/e2e/v4/plugin_cluster_test.go
@@ -107,6 +107,14 @@ func Run(kbc *utils.TestContext) {
 	err = kbc.Tidy()
 	ExpectWithOffset(1, err).NotTo(HaveOccurred())
 
+	By("run make manifests")
+	err = kbc.Make("manifests")
+	ExpectWithOffset(1, err).NotTo(HaveOccurred())
+
+	By("run make generate")
+	err = kbc.Make("generate")
+	ExpectWithOffset(1, err).NotTo(HaveOccurred())
+
 	By("building the controller image")
 	err = kbc.Make("docker-build", "IMG="+kbc.ImageName)
 	ExpectWithOffset(1, err).NotTo(HaveOccurred())