Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaffolds hub and spoke interfaces for conversion webhooks. #2589

Open
camilamacedo86 opened this issue Apr 2, 2022 · 18 comments
Open

scaffolds hub and spoke interfaces for conversion webhooks. #2589

camilamacedo86 opened this issue Apr 2, 2022 · 18 comments
Assignees
@lauchokyip @26tanishabanik @momom-i @ashutosh887
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

scaffolds hub and spoke interfaces for conversion webhooks.
With this change, users can either specify --conversion flag and implement
the interface on their own, or specify --hub and --spoke versions which
will scaffold the skeleton code for both the interfaces.

Follow up/finish the work which started : #2084

Extra Labels

No response
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 2, 2022
@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented May 3, 2022 •
edited

@camilamacedo86 What do we need to do here?

Do we need to:

?

@camilamacedo86 camilamacedo86 added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 5, 2022
@NikhilSharmaWe
Copy link
Member

@camilamacedo86 Could you please take a look at my previous comment.

@camilamacedo86
Copy link
Member Author

Sure. Please, feel free to work on this one.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2022
@laxmikantbpandhare
Copy link
Member

/assign I can take a look into it.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 11, 2022
@camilamacedo86 camilamacedo86 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 12, 2022
@camilamacedo86
Copy link
Member Author

Yes, the goal of this task is to finalize the implementation done in the #2084. So, you can get the changes made and address the comments.

IN this way, this one seems a good fit for the good first issue.

@camilamacedo86 camilamacedo86 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 12, 2022
@26tanishabanik
Copy link

/assign

@momom-i
Copy link

momom-i commented Oct 28, 2022

@camilamacedo86 Is it already done? If not, I'd like to work on this!

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Oct 28, 2022 •
edited

Hi @momom-i.

It is not. Please, feel free to work on this one.
Your collaboration is very welcome.

I do not think that @26tanishabanik has been work on this.
@26tanishabanik if you are doing it please, let us know.

Thx.

@momom-i momom-i mentioned this issue Nov 3, 2022
Closed
@momom-i momom-i mentioned this issue Feb 4, 2023
Closed
@ashutosh887
Copy link
Contributor

I don't think it's still resolved
I would like to work on this now

/assign

@momom-i
Copy link

momom-i commented Feb 26, 2023

@ashutosh887 I’m working on this now.
/assign

@ashutosh887
Copy link
Contributor

Sure @momom-i
Please let me know if you need any help

@ashutosh887
Copy link
Contributor

Let me work on this @camilamacedo86 if @momom-i is unable to resolve

@lauchokyip
Copy link
Contributor

/assign

@momom-i
Copy link

momom-i commented May 15, 2023

/assign

@lauchokyip
Copy link
Contributor

lauchokyip commented May 15, 2023 •
edited

For anyone who is interested in working on this PR, IMHO, I do not think it's a good-first-issue. It requires good amount of knowledge for Go, cli and Kubernetes Webhook. You would also need to read the design proposals to come up with the best practice. Simply copy and paste the OP's PR will not work.

Estimated time from understanding to coding to open an PR and to get it merged would require at least a month of effort

@lauchokyip lauchokyip mentioned this issue May 22, 2023
Closed
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauchokyip lauchokyip

@26tanishabanik 26tanishabanik

@momom-i momom-i

@ashutosh887 ashutosh887

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@camilamacedo86 @k8s-ci-robot @lauchokyip @laxmikantbpandhare @26tanishabanik @momom-i @k8s-triage-robot @ashutosh887 @NikhilSharmaWe