New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added copyrights #1286
Added copyrights #1286
Conversation
Welcome @hmanikkothu! |
Hi @hmanikkothu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You handled all the files I mentioned in #1281. The only doubt I have is if they should be 2020 copyrights or each file should have a copyright of the year it was created.
Otherwise, LGTM.
package prometheus | ||
|
||
import ( | ||
"path/filepath" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: I completely agree with this blank line, I actually authored #1187, but I would not change it in this PR as it is not related to the same topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will revert this.
2020 copyrights are fine /approve (P.S. for future reference, minor formatting changes in a PR are generally fine. I often prefer to put them in a separate commit, but something like "there should really be a blank line here" are fine to do as you notice them ;-) ) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, hmanikkothu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Added copyrights to the following files:
/build/.goreleaser.yml
/docs/book/install-and-build.sh
/docs/book/litgo.sh
/docs/book/markerdocs.sh
/cmd/util/validations.go
/pkg/model/types.go
/pkg/scaffold/scaffold_suite_test.go
/pkg/scaffold/scaffold_test.go
/pkg/scaffold/input/input_suite_test.go
/pkg/scaffold/input/input_test.go
/pkg/scaffold/project/project_suite_test.go
/pkg/scaffold/project/project_test.go
/pkg/scaffold/resource/resource_suite_test.go
/pkg/scaffold/resource/resource_test.go
/pkg/scaffold/v1/crd/suite_test.go
/pkg/scaffold/v1/manager/manager_suite_test.go
/pkg/scaffold/v1/manager/manager_test.go
/pkg/scaffold/v1/webhook/webhook_suite_test.go
/pkg/scaffold/v1/webhook/webhook_test.go
/pkg/scaffold/v2/prometheus/monitor.go
/scripts/generate_dep_manifest.sh
/scripts/install.sh
/test/kind-config.yaml
Motivation
Fixes #1281