Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copyrights #1286

Merged
merged 1 commit into from Jan 7, 2020
Merged

Added copyrights #1286

merged 1 commit into from Jan 7, 2020

Conversation

hmanikkothu
Copy link
Contributor

Description
Added copyrights to the following files:
/build/.goreleaser.yml
/docs/book/install-and-build.sh
/docs/book/litgo.sh
/docs/book/markerdocs.sh
/cmd/util/validations.go
/pkg/model/types.go
/pkg/scaffold/scaffold_suite_test.go
/pkg/scaffold/scaffold_test.go
/pkg/scaffold/input/input_suite_test.go
/pkg/scaffold/input/input_test.go
/pkg/scaffold/project/project_suite_test.go
/pkg/scaffold/project/project_test.go
/pkg/scaffold/resource/resource_suite_test.go
/pkg/scaffold/resource/resource_test.go
/pkg/scaffold/v1/crd/suite_test.go
/pkg/scaffold/v1/manager/manager_suite_test.go
/pkg/scaffold/v1/manager/manager_test.go
/pkg/scaffold/v1/webhook/webhook_suite_test.go
/pkg/scaffold/v1/webhook/webhook_test.go
/pkg/scaffold/v2/prometheus/monitor.go
/scripts/generate_dep_manifest.sh
/scripts/install.sh
/test/kind-config.yaml

Motivation
Fixes #1281

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @hmanikkothu!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @hmanikkothu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You handled all the files I mentioned in #1281. The only doubt I have is if they should be 2020 copyrights or each file should have a copyright of the year it was created.

Otherwise, LGTM.

package prometheus

import (
"path/filepath"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: I completely agree with this blank line, I actually authored #1187, but I would not change it in this PR as it is not related to the same topic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will revert this.

@DirectXMan12
Copy link
Contributor

2020 copyrights are fine

/approve
/lgtm

(P.S. for future reference, minor formatting changes in a PR are generally fine. I often prefer to put them in a separate commit, but something like "there should really be a blank line here" are fine to do as you notice them ;-) )

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, hmanikkothu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 50008f5 into kubernetes-sigs:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing copyrights
4 participants