Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add/update CLI plugin docs #1539

Closed

Conversation

estroz
Copy link
Contributor

@estroz estroz commented May 31, 2020

Plugin versions do not need to contain a patch version number, since patch-like changes should not require the user to change their config's layout value. This commit rewrites and adds some documentation on general plugin development and versioning.

See #1519 (comment) for details.

Will follow up with patch version removal once #1536 is merged, which will allow both patched and non-patched version (v2.0.0 vs v2.0) resolution without a breaking change.

/cc @camilamacedo86 @DirectXMan12 @joelanford

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2020
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
@@ -133,3 +152,5 @@ KubeBuilder and the related repositories. See

Participation in the Kubernetes community is governed by the [Kubernetes Code of Conduct](code-of-conduct.md).

[releases]:ttps://github.com/kubernetes-sigs/kubebuilder/releases
[plugins-design-versioning]:design/extensible-cli-and-scaffolding-plugins-phase-1.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links are broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@kubernetes-sigs kubernetes-sigs deleted a comment from estroz Jun 1, 2020
@kubernetes-sigs kubernetes-sigs deleted a comment from estroz Jun 1, 2020
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits .. Otherwise I am ok with.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
designs/extensible-cli-and-scaffolding-plugins-phase-1.md Outdated Show resolved Hide resolved
@estroz estroz changed the title docs,plugins: update versioning semantics and add/reorg plugin docs. docs: add/update CLI plugin docs Jun 1, 2020
@estroz estroz force-pushed the docs/versioning-updates branch 2 times, most recently from 3579158 to dae4ef5 Compare June 5, 2020 16:36
| PROJECT version | `v1`,`v2`,`v3` | As of the introduction of [Extensible CLI and Scaffolding Plugins](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/extensible-cli-and-scaffolding-plugins-phase-1.md), PROJECT version represents the layout of PROJECT file itself. For `v1` and `v2` projects, there's extra meaning -- see below. |
| Release version | `v2.2.0`, `v2.3.0`, `v2.3.1` | Tagged versions of the KubeBuilder project, representing changes to the source code in this repository. See the [releases](https://github.com/kubernetes-sigs/kubebuilder/releases) page. |
| Plugin Versions | `go.kubebuilder.io/v2.0.0` | Represents the version of an individual plugin, as well as the corresponding scaffolding that it generates. |
| KubeBuilder version | `v2.2.0`, `v2.3.0`, `v2.3.1` | Tagged versions of the KubeBuilder project, representing changes to the source code in this repository. See the [releases][kb-releases] page for binary releases. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Until we are able to update it related to the latest changes.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2020
@estroz
Copy link
Contributor Author

estroz commented Jul 1, 2020

@camilamacedo86 @DirectXMan12 these docs changes reflect the most recent plugin spec changes and should be ok to merge.

on general development and versioning.

docs/book/src/reference/cli-plugins.md: document current CLI plugin details here
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020
@estroz
Copy link
Contributor Author

estroz commented Jul 14, 2020

/test pull-kubebuilder-e2e-k8s-1-17-0

@camilamacedo86
Copy link
Member

HI @estroz this content was moved to VERSIONING.md. Could you please update your PR for we are able to get it merged?

@k8s-ci-robot
Copy link
Contributor

@estroz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2020
@camilamacedo86
Copy link
Member

Hi @estroz,

Since it is open for too long without interaction, in order to us be able to close this issue #1519 I pushed your changes in the VERSIONING.md doc which is the place where it is now via the PR: #1769. Would be very nice to get your help to review on that.

In this way, I hope that is fine we close this one. However, feel free to re-open if you see that is required.

@estroz
Copy link
Contributor Author

estroz commented Nov 2, 2020

/reopen

@k8s-ci-robot
Copy link
Contributor

@estroz: Failed to re-open PR: state cannot be changed. The docs/versioning-updates branch was force-pushed or recreated.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz estroz mentioned this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants