🐛 fix unit tests to work with later versions of ginkgo/gomega #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Adirio
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
I have to blame myself about this one.
Same happened in operator SDK (relevant commits: operator-framework/operator-sdk@f1f5926 and operator-framework/operator-sdk@5a5c4fc).
Also, as we are planning on exporting this packages (#2036), this fix is pretty well timed. I was actually planning on doing this myself.
/lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was re-using some of the internal packages in
pkg/plugins/internalin a project that requires more recent versions of Ginkgo and Gomega and I noticed that the tests fail due to duplicate calls toRunSpecs.We should call
RunSpecsonly once in each package. See onsi/ginkgo#704 (comment) for what led me to this conclusion.Also going ahead an bumping our deps to trigger this feedback in the future.