Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Decouple plugin requirements from Config interface #2047

Merged
merged 1 commit into from
Feb 26, 2021
Merged

⚠️ Decouple plugin requirements from Config interface #2047

merged 1 commit into from
Feb 26, 2021

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Feb 26, 2021

Extract the single version per config file out of config as it is a plugin restriction, not a project configuration file restriction.

Closes: #2046

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2021
@Adirio Adirio mentioned this pull request Feb 26, 2021
Closed
14 tasks
@Adirio Adirio force-pushed the config-interface branch 2 times, most recently from 096d89c to 2f57980 Compare February 26, 2021 09:40
@Adirio Adirio changed the title ⚠️ Generalize CRD and webhook version related methods in Config ⚠️ Decouple plugin requirements from Config interface Feb 26, 2021
@Adirio
Generalize CRD and webhook version related methods in Config
1586c2d 
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
camilamacedo86
camilamacedo86 reviewed Feb 26, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change. Note that the config is responsible to have funcs to return its values, however, the rule to allow or not different APIs is specific to the plugin since we could, for example, support it for go/v4.

In this way, since it is a very small and concise change that does not affect the end-user behaviours and is only more a cleanup. I am happy in

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2021
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-16-15

@k8s-ci-robot k8s-ci-robot merged commit 0610cc8 into kubernetes-sigs:master Feb 26, 2021
@Adirio Adirio deleted the config-interface branch February 26, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Final Config interface for v3.0.0
3 participants
@Adirio @k8s-ci-robot @camilamacedo86