Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Add https to the webpage #2050

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Mar 1, 2021

Rightnow the link does not contain the https in the URL, with this change it will be easy for the user to just click on the error message and view the content instead of copy-pasting the URL.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2021
@mkumatag mkumatag changed the title (:bug:): Add https to the webpage 馃悰Add https to the webpage Mar 1, 2021
@mkumatag mkumatag changed the title 馃悰Add https to the webpage 馃悰 Add https to the webpage Mar 1, 2021
@mkumatag mkumatag changed the title 馃悰 Add https to the webpage 馃悰 Add https to the webpage Mar 1, 2021
@mkumatag
Copy link
Member Author

mkumatag commented Mar 1, 2021

/retest

1 similar comment
@mkumatag
Copy link
Member Author

mkumatag commented Mar 1, 2021

/retest

@mkumatag
Copy link
Member Author

mkumatag commented Mar 1, 2021

pretty straight forward fix, can someone review this PR: @kubebuilder-approvers

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 馃憤

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 80177d3 into kubernetes-sigs:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants