⚠️ Inject filesystem from CLI instead of creating several per command #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
14 tasks
Adirio
force-pushed
the
inject-filesystem
branch
from
f31866d
to
1761213
Compare
camilamacedo86
approved these changes
Mar 10, 2021
This was referenced Mar 10, 2021
estroz
reviewed
Mar 12, 2021
estroz
reviewed
Mar 12, 2021
k8s-ci-robot
added
size/XL
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
Adirio
force-pushed
the
inject-filesystem
branch
from
5bbf9ad
to
a2cc78c
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new filesystem abstraction is being created in multiple places. This PRs creates a single filesystem abstraction in the CLI, and passes/injects it to any machinery that requires it.
Technically speaking this is a brekaing change, because it modifies the
Subcommandinterface inpkg/plugin/interfaces.go. This, and the corresponding signature update for the plugins, is the only breaking change in this PR. It is required to expose both the scaffolding machinery (#2036) and the config file machinery (#2056).