✨ Provide third-party devs the option to provide their own alpha subcommands #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mands Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
camilamacedo86
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
After the #1831 get merged we cannot align SDK with KB because both have alpha commands. This pr solves this problem.
Great work 🥇
/lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK is providing an alpha command, we are doing the same, when we try to align them, they will collide.
This PRs provides a way to set extra alpha commands for third-party developers.