Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable the storage of multiple plugins as layout #2096

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Mar 17, 2021

Use a custom type to ensure backwards compatibility: older configuration files will unmarshall properly despite not being an array and will marshal to the new format.

/kind feature

@Adirio Adirio added this to the v3.0.0 milestone Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2021
@k8s-ci-robot k8s-ci-robot requested a review from droot March 17, 2021 13:42
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2021
@Adirio
Copy link
Contributor Author

Adirio commented Mar 17, 2021

@camilamacedo86 @estroz @DirectXMan12 @jmrodri this is what we were discussing yesterday.

Use a custom type to ensure backwards compatibility: older configuration files will unmarshall properly despite not being an array and will marshal to the new format.

Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@Adirio Adirio removed the request for review from droot March 17, 2021 16:24
@estroz
Copy link
Contributor

estroz commented Mar 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021
@estroz estroz merged commit 406d79d into kubernetes-sigs:master Mar 17, 2021
@Adirio Adirio deleted the config-chain branch March 17, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants