Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add the common plugin(s) to allow it to be used by consumers #2106

Merged
merged 1 commit into from
Apr 7, 2021
Merged

✨ add the common plugin(s) to allow it to be used by consumers #2106

merged 1 commit into from
Apr 7, 2021

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Mar 25, 2021 •
edited

Description

  • ✨ add the common plugin(s) to allow it to be used by consumers
  • organize the plugins as suggested to make clear what is common and what is language-based.

Screen Shot 2021-03-27 at 08 51 28

  • plugins/common: Here we will have ANY plugin that is common and not based in any language such as config-gen, and this one config-base.
  • plugins/golang: Here we have all plugins whcih are ONLY valid for Golang.

Motivation
Closes: #2015
To check more about its motivation see: https://deploy-preview-2115--kubebuilder.netlify.app/plugins/creating-plugins.html#language-based-plugins
PR which was done for SDK: operator-framework/operator-sdk#4701 in order to show that worked and its result.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2021
@camilamacedo86 camilamacedo86 changed the title WIP: create base plugin to allow which be used by consumers WIP: create base plugin to allow it be used by consumers Mar 25, 2021
Adirio
Adirio suggested changes Mar 25, 2021
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 25, 2021
Adirio
Adirio reviewed Mar 25, 2021
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
Adirio
Adirio reviewed Mar 25, 2021
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
Adirio
Adirio reviewed Mar 25, 2021
View reviewed changes
pkg/cli/cli.go Outdated Show resolved Hide resolved
@camilamacedo86 camilamacedo86 force-pushed the config-base branch 2 times, most recently from 5060290 to 5d091de Compare March 25, 2021 13:02
@camilamacedo86

This comment has been minimized.

Sign in to view
Adirio
Adirio suggested changes Mar 30, 2021
View reviewed changes
pkg/plugins/common/config-base/v1/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/common/config-base/v1/init.go Outdated Show resolved Hide resolved
pkg/plugins/common/config-base/v1/init.go Outdated Show resolved Hide resolved
pkg/plugins/common/config-base/v1/init.go Outdated Show resolved Hide resolved
pkg/plugins/golang/v3/init.go Outdated Show resolved Hide resolved
pkg/plugins/golang/v3/scaffolds/api.go Outdated Show resolved Hide resolved
pkg/plugins/golang/v3/scaffolds/init.go Outdated Show resolved Hide resolved
@camilamacedo86 camilamacedo86 force-pushed the config-base branch 3 times, most recently from 5cd2d3e to d191d2b Compare March 30, 2021 22:40
Adirio
Adirio reviewed Mar 31, 2021
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
pkg/plugins/common/kustomize-common/v1/init.go Outdated Show resolved Hide resolved
pkg/plugins/common/config-base/v1/init.go Outdated Show resolved Hide resolved
Adirio
Adirio previously requested changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final comments

estroz
estroz suggested changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All kustomize-related files should be in the kustomize plugin

@camilamacedo86 camilamacedo86 force-pushed the config-base branch 2 times, most recently from 4a304dc to cb11d5c Compare April 1, 2021 16:25
estroz
estroz approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 dismissed Adirio’s stale review April 7, 2021 15:04

@Adirio, since you approved it before and the latest comments were small nits which indeed are addressed and you are without time to check this one I will be moving forward here. However, see that we can do a follow if required OK. I hope that is fine.

@camilamacedo86
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit d5e70a5 into kubernetes-sigs:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

@Adirio Adirio Awaiting requested review from Adirio

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract config/base plugin valid for any language/type from Golang
4 participants
@camilamacedo86 @Adirio @k8s-ci-robot @estroz