Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix typo todo text for resource values #2378

Merged
merged 1 commit into from Oct 13, 2021
Merged

🐛 fix typo todo text for resource values #2378

merged 1 commit into from Oct 13, 2021

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Oct 12, 2021 •
edited

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@camilamacedo86 camilamacedo86 changed the title fix: typo todo text for resource values bug: typo todo text for resource values Oct 12, 2021
@camilamacedo86 camilamacedo86 changed the title bug: typo todo text for resource values bug: fix typo todo text for resource values Oct 12, 2021
@camilamacedo86 camilamacedo86 changed the title bug: fix typo todo text for resource values 🐛 fix typo todo text for resource values Oct 12, 2021
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-test

rashmigottipati
rashmigottipati approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit a2e5d00 into kubernetes-sigs:master Oct 13, 2021
@camilamacedo86 camilamacedo86 deleted the fix-typo branch October 22, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@Adirio Adirio Awaiting requested review from Adirio

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@rashmigottipati rashmigottipati

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @rashmigottipati