Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 deploy-image/v1alpha: fix small issues #2835

Merged
merged 1 commit into from Jul 25, 2022
Merged

🐛 deploy-image/v1alpha: fix small issues #2835

merged 1 commit into from Jul 25, 2022

Conversation

NikhilSharmaWe
Copy link
Member

@NikhilSharmaWe NikhilSharmaWe commented Jul 23, 2022 •
edited by camilamacedo86

Description

This PR fixes some issues which are:

a) The scenario where we should only add the Recorder to be passed to the controller when the API/controller was scaffolded with the plugin
b) The scenario where we are scaffolding an extra }} in the controller by mistake in the logs
c) Fix log typo

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2022
@camilamacedo86 camilamacedo86 changed the title ✨deploy-image/v1alpha: fix the recorder scaffold in main.go 🐛 deploy-image/v1alpha: fix the recorder scaffold in main.go and the extra }} scaffold in the controller Jul 25, 2022
@camilamacedo86 camilamacedo86 changed the title 🐛 deploy-image/v1alpha: fix the recorder scaffold in main.go and the extra }} scaffold in the controller 🐛 deploy-image/v1alpha: fix small issues Jul 25, 2022
camilamacedo86
camilamacedo86 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥇

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 68c51e9 into kubernetes-sigs:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NikhilSharmaWe @k8s-ci-robot @camilamacedo86