-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 missing shell argument in autocompletion snippet #3143
Conversation
The documentation's snippet was missing the shell argument, so the code was not working if added to the .bash_profile.
|
Welcome @GabriFedi97! |
Hi @GabriFedi97. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GabriFedi97 thanks for the contribution! These changes look good to me!
/lgtm
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven, GabriFedi97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Could you please rebase this one with the master branch so we can get it merged? |
New changes are detected. LGTM label has been removed. |
@camilamacedo86 Done! |
The documentation's snippet provided to enable the autocompletion, uses the command
kubebuilder completion zsh|bash|powershell|fish
but the argument is missing. Looks like it should be a ready to go, copy & paste, snippet to be added to the.bash_profile
but it does not work as it is, due to the missing argument.Since the example relies on the shell
bash
, according to thekubebuilder completion
subcommand documentation, the missing argument should be fed withbash
.