⚠️ (go/v4): upgrade controller runtime from 0.14 to 0.15

[camilamacedo86]

Description

This PR upgrade controller runtime from 0.14 to 0.15.
Bump declarative partner for go/v4
Ensure that new declarative versions are only used on go/v4

Motivation

Fixes: #3376

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Closed in favor of : #3421

[k8s-ci-robot]

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-test	c0cae8f	link	true	/test pull-kubebuilder-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kkkkun]

Should update kubebuilder-declarative-pattern to v0.13.0-beta.1.0.20230604223042-9a410556b95d
such as d5ff1ae

[camilamacedo86]

@yyy1000 here is were we are bumping the declarative version
See that we should not bump for go/v3
because of this we need to change a little the code

[camilamacedo86]

@kkkkun

Should update kubebuilder-declarative-pattern to v0.13.0-beta.1.0.20230604223042-9a410556b95d
such as d5ff1ae

See: https://github.com/kubernetes-sigs/kubebuilder/pull/3394/files#r1224363051
So if you change your PR accordingly please feel free.

[camilamacedo86]

@kkkkun,

I am happy to merge your PR if you shape there. I am just moving forward here in order to help out and we have the changes asap. See that we still with an issue in the declarative one

>internal/controller/firstmate_controller.go:83:11: assignment mismatch: 2 variables but declarative.WatchAll returns 1 value
# sigs.k8s.io/kubebuilder/testdata/project-v4-declarative-v1/internal/controller
vet: internal/controller/admiral_controller.go:77:17: source.Kind (value of type func(cache "sigs.k8s.io/controller-runtime/pkg/cache".Cache, object "sigs.k8s.io/controller-runtime/pkg/client".Object) source.SyncingSource) is not a type
make[1]: *** [Makefile:61: vet] Error 1
make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/kubebuilder/testdata/project-v4-declarative-v1'
make: *** [Makefile:134: test-testdata] Error 2

PLease, check if bump the versions informed by you would solve that but ensure that your PR does: See: https://github.com/kubernetes-sigs/kubebuilder/pull/3394/files#r1224363051

[kkkkun]

@kkkkun,

I am happy to merge your PR if you shape there. I am just moving forward here in order to help out and we have the changes asap. See that we still with an issue in the declarative one

>internal/controller/firstmate_controller.go:83:11: assignment mismatch: 2 variables but declarative.WatchAll returns 1 value
# sigs.k8s.io/kubebuilder/testdata/project-v4-declarative-v1/internal/controller
vet: internal/controller/admiral_controller.go:77:17: source.Kind (value of type func(cache "sigs.k8s.io/controller-runtime/pkg/cache".Cache, object "sigs.k8s.io/controller-runtime/pkg/client".Object) source.SyncingSource) is not a type
make[1]: *** [Makefile:61: vet] Error 1
make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/kubebuilder/testdata/project-v4-declarative-v1'
make: *** [Makefile:134: test-testdata] Error 2

PLease, check if bump the versions informed by you would solve that but ensure that your PR does: See: https://github.com/kubernetes-sigs/kubebuilder/pull/3394/files#r1224363051

OK. I woulld retry it.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

Closing this one in favor of another PR for we move forward within