Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 fix title to make clear plugins which are deprecated #3568

Merged
merged 1 commit into from
Aug 28, 2023
Merged

📖 fix title to make clear plugins which are deprecated #3568

merged 1 commit into from
Aug 28, 2023

Conversation

camilamacedo86
Copy link
Member

Description

Just fix the docs to ensure that we make clear the plugins which are deprecated.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2023
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2023
@camilamacedo86
Copy link
Member Author

moving forward with this one because it is a very nit fix in the docs.
Not valuble ask for someone wast time doing reviews.

Kavinjsir
Kavinjsir approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-26-0

3 similar comments
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-26-0

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-26-0

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-26-0

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-25-3

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-26-0

@k8s-ci-robot k8s-ci-robot merged commit 98194e3 into kubernetes-sigs:master Aug 28, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Kavinjsir approved these changes

@everettraven everettraven Awaiting requested review from everettraven

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @Kavinjsir