Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ : upgrade k8s 1.27.1 to 1.28.0 and controller-runtime from 0.15.0 to 0.16.0 #3570

Merged

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Aug 26, 2023

Description

  • Upgrade k8s from 1.27.1 to 1.28.0
  • Upgrade controller-runtime from 0.15.0 to 0.16.0

⚠️ Controller-runtime has breaking changes see: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0. Note that the some changes was required to be introduced in the main.go and in the webhook suite test.

  1. Convert Manager Option field MetricsBindAddress to Metrics.
    (Relative PR: ⚠ Introduce Metrics Options struct & secure metrics serving controller-runtime#2407)
    2. Remove Manager Option fields Host, Port, CertDir since they are deprecated and set by default webhook options.
    (Relative PR: ⚠ Remove deprecated manager, webhook and cluster options controller-runtime#2422)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 26, 2023
@camilamacedo86 camilamacedo86 changed the title ⚠️ upgrade k8s 1.27.1 to 1.28.0 and controller-runtime from 0.15.0 to 0.16.0 ⚠️ : upgrade k8s 1.27.1 to 1.28.0 and controller-runtime from 0.15.0 to 0.16.0 Aug 26, 2023
@Kavinjsir
Copy link
Contributor

Kavinjsir commented Aug 26, 2023

@camilamacedo86 Looks like we have duplicate works, I just close my #3569 as per duplicate here.

One issue happens to me is that, when running make test-testdata, it would fail in testdata/project-v4-declarative-v1, where errors occur when running go vet:

❯ make vet
go vet ./...
# sigs.k8s.io/kustomize/kyaml/openapi
../../../../go/pkg/mod/sigs.k8s.io/kustomize/kyaml@v0.13.9/openapi/openapi.go:656:33: cannot use doc (variable of type *"github.com/google/gnostic/openapiv2".Document) as *"github.com/google/gnostic-models/openapiv2".Document value in argument to swagger.FromGnostic
# k8s.io/kubectl/pkg/util/openapi
../../../../go/pkg/mod/k8s.io/kubectl@v0.26.3/pkg/util/openapi/openapi_getter.go:36:42: cannot use &CachedOpenAPIGetter{} (value of type *CachedOpenAPIGetter) as discovery.OpenAPISchemaInterface value in variable declaration: *CachedOpenAPIGetter does not implement discovery.OpenAPISchemaInterface (wrong type for method OpenAPISchema)
                have OpenAPISchema() (*"github.com/google/gnostic/openapiv2".Document, error)
                want OpenAPISchema() (*"github.com/google/gnostic-models/openapiv2".Document, error)
../../../../go/pkg/mod/k8s.io/kubectl@v0.26.3/pkg/util/openapi/openapi_getter.go:49:28: cannot use g.openAPIClient.OpenAPISchema() (value of type *"github.com/google/gnostic-models/openapiv2".Document) as *"github.com/google/gnostic/openapiv2".Document value in assignment
../../../../go/pkg/mod/k8s.io/kubectl@v0.26.3/pkg/util/openapi/openapi_getter.go:78:46: cannot use oapi (variable of type *"github.com/google/gnostic-models/openapiv2".Document) as *"github.com/google/gnostic/openapiv2".Document value in argument to NewOpenAPIData
../../../../go/pkg/mod/k8s.io/kubectl@v0.26.3/pkg/util/openapi/openapi.go:52:38: cannot use doc (variable of type *"github.com/google/gnostic/openapiv2".Document) as *"github.com/google/gnostic-models/openapiv2".Document value in argument to proto.NewOpenAPIData
make: *** [vet] Error 1
~/pro/kubebuilder/testdata/project-v4-declarative-v1 bump-controller-runtime*

I'm looking into why, though not quite familiar with the declarative plugin..

@camilamacedo86
Copy link
Member Author

/hold

Blocked by bump the project: https://github.com/kubernetes-sigs/kubebuilder-declarative

And then, get the commit within the changes.

c/c @varshaprasad96 @Kavinjsir

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2023
@camilamacedo86
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2023
@camilamacedo86
Copy link
Member Author

I will move forward with this one.
When we bump controller-runtime we need to force.

@camilamacedo86 camilamacedo86 merged commit c399f0c into kubernetes-sigs:master Sep 1, 2023
14 of 16 checks passed
@camilamacedo86 camilamacedo86 deleted the upgrade-k8s-128 branch September 1, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants