Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 supplement doc over alpha generate command #3602

Merged
merged 1 commit into from Sep 11, 2023
Merged

馃摉 supplement doc over alpha generate command #3602

merged 1 commit into from Sep 11, 2023

Conversation

camilamacedo86
Copy link
Member

Description

  • Ensure that you describe how the command work and show examples of it usage
  • Add the command to the migration guide as a help
  • Add links of reference for the command
  • Add the doc to the index

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2023
@camilamacedo86 camilamacedo86 requested review from Kavinjsir and removed request for rashmigottipati and everettraven September 7, 2023 09:50
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-27-1

yyy1000
yyy1000 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@yyy1000 yyy1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your supplement.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, yyy1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yyy1000
Copy link
Member

yyy1000 commented Sep 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit a9ba582 into kubernetes-sigs:master Sep 11, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@yyy1000 yyy1000 Awaiting requested review from yyy1000

Assignees

@yyy1000 yyy1000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @yyy1000